Skip to main content

Review loop and human approval

Every pull request ThriveOnDev opens is reviewed by a separate run before it can be merged. If the review asks for changes, the agent fixes them and the pull request is reviewed again, up to three automatic rounds. Owners and admins can also require a person's approval before any merge.

How the review loop works​

  1. The implement run opens a pull request, and the issue moves to In Review.
  2. A review run checks the pull request against the issue, using your workspace's reviewer agent.
  3. If the review approves, the task moves on to release, or to human approval if your workspace requires it.
  4. If the review requests changes, the issue moves back to In Progress. A fix-review run addresses the findings on the same pull request, and then it is reviewed again.

When the loop stops​

After three automatic fix-review rounds, the next rejection pauses the loop. The agent leaves a comment that starts with "Automatic fix-review paused." and starts no new session. The issue stays in In Review.

Nothing else changes: the assignee, labels and status stay as they are. A person decides what happens next. Usually you do one of these:

  • Clarify the issue if the review and the implementation disagree about what was asked, then comment /fix-review.
  • Fix the pull request yourself, then comment /review for a fresh review.
  • Close the pull request if the task is not worth continuing.

Change requests from people don't count toward the three rounds. The count starts again when the task reaches human approval, release or done.

Require human approval before release​

By default, a pull request that passes review is merged once its CI checks pass. To have a person approve every pull request first:

  1. Open Settings → Team.
  2. Turn on Require human approval before release.

Only owners and admins can change this setting. When it is on:

  • An approved pull request moves to In Human Review. ThriveOnDev creates this Linear status if your team does not have it.
  • The task waits for an approving review in GitHub.
  • If the person requests changes in GitHub, the task goes back to fix review.

Turning it off asks you to confirm Release without human approval?, because pull requests will then merge without a person.

What review checks​

The review run reads the issue and the pull request and checks that the change does what the issue asks and that it is safe to merge. The clearer your acceptance criteria, the more useful the review. See Write issues an agent can finish.